Repository navigation
Rollup of 4 pull requests - #164535
Merged
Merged
Rollup of 4 pull requests#164535
Conversation
On my machine, this gives about -1.10% instruction count on Diesel (avg over all the diesel benchmarks) and gives some wins on all other benchmarks (except `ucd` for some reason).
Instead of walking up the call stack each time we need the caller location, we emulate the run time behavior of passing an implicit caller location argument in #[track_caller] functions. We record a representation of that argument in each frame. For inlined functions though, we still do a "stack walk" within that one frame.
…k-Simulacrum Rename `bstr` module/feature to `byte_str` This also renames the various features to use `byte_str` instead of `bstr`. This was [discussed](https://github.com/rust-lang/libs-team/blob/main/minutes/2026-08-25.md#nominated-rusttf160912-rename-bstr-modulefeature-to-byte_str) by libs and agreed on as being more consistent with the types contained in the module. However, we remain open to renaming back before stabilization if warranted. For now, `byte_str::ByteStr` makes the most sense. (To be clear, `bstr::ByteStr` and `byte_str::BStr` are both undesired.)
…nnethercote perf: inline `Clause::map_bound`
…on, r=RalfJung consteval: Rework caller location handling Instead of walking up the call stack each time we need the caller location, we emulate the run time behavior of passing an implicit caller location argument in `#[track_caller]` functions. We record a representation of that argument in each frame. For inlined functions though, we still do a "stack walk" within that one frame. This PR is a prerequisite for rust-lang#163396 Fixes rust-lang/miri#5351
add core::process::resumable_breakpoint This is an alternative to `arch::breakpoint`. Same implementation, very different docs. (Also the implementation in CTFE / Miri would likely be different.) Tracking issue: rust-lang#133724 r? @tgross35
rustbot
added
O-apple
Member
Author
|
@bors r+ p=5 force |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 15c1044 (parent) -> b6eeb93 (this PR) Test differencesShow 42 test diffsStage 1
Stage 2
Additionally, 28 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard b6eeb93c992027a03e1fd120b6652546396b142c --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (b6eeb93): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (secondary 1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 0.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 490.17s -> 489.811s (-0.07%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: 15c10447a4 In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
bstrmodule/feature tobyte_str#160912 (Renamebstrmodule/feature tobyte_str)Clause::map_bound#164463 (perf: inlineClause::map_bound)r? @ghost
Create a similar rollup