Skip to content

[tiny] Tweak incorrect #[default] errors - #165573

Open
estebank wants to merge 1 commit into
rust-lang:mainfrom
estebank:default-context
Open

estebank wants to merge 1 commit into
rust-lang:mainfrom
estebank:default-context

Conversation

@estebank

@estebank estebank commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Add more code context and tweak wording.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 7, 2026
@rustbot

rustbot commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 79 candidates
  • Random selection from 22 candidates

@JohnTitor JohnTitor left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 598a3e2 has been approved by JohnTitor

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 7, 2026
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2026
@rust-bors

This comment has been minimized.

Add more code context and tweak wording.
@rustbot

rustbot commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@estebank

estebank commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=JohnTitor

@rust-bors

rust-bors Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 04f973d has been tentatively approved by JohnTitor

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 8, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 8, 2026
[tiny] Tweak incorrect `#[default]` errors

Add more code context and tweak wording.
rust-bors Bot pushed a commit that referenced this pull request Nov 8, 2026
Rollup of 8 pull requests

Successful merges:

 - #164720 (Expand E0271 on return type)
 - #165301 (Fix struct-literal suggestion spans in macros)
 - #165573 ([tiny] Tweak incorrect `#[default]` errors)
 - #164036 ([rustdoc] Allow `.` to be used the same as `::` in the search)
 - #165457 (tests: llvm 24 can merge addrspace declarations again)
 - #165462 (Use `emit_ptr_va_arg` for `va_arg` on AVR)
 - #165609 (OIDC artifact pushes)
 - #165620 (change return type of FloatErrorKind::kind)
rust-bors Bot pushed a commit that referenced this pull request Nov 8, 2026
Rollup of 8 pull requests

Successful merges:

 - #164720 (Expand E0271 on return type)
 - #165301 (Fix struct-literal suggestion spans in macros)
 - #165573 ([tiny] Tweak incorrect `#[default]` errors)
 - #164036 ([rustdoc] Allow `.` to be used the same as `::` in the search)
 - #165457 (tests: llvm 24 can merge addrspace declarations again)
 - #165462 (Use `emit_ptr_va_arg` for `va_arg` on AVR)
 - #165609 (OIDC artifact pushes)
 - #165620 (change return type of FloatErrorKind::kind)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants