refactor(cli/self-update)!: reorganize InstallOpts methods#4950
Merged
Conversation
rami3l
commented
Jul 10, 2026
rami3l
force-pushed
the
refactor/install-opts-cleanup
branch
5 times, most recently
from
July 10, 2026 14:39
cc981f1 to
c85a63c
Compare
This comment has been minimized.
This comment has been minimized.
rami3l
force-pushed
the
refactor/install-opts-cleanup
branch
from
July 10, 2026 20:23
c85a63c to
de49ea3
Compare
rami3l
marked this pull request as ready for review
July 14, 2026 08:03
rami3l
force-pushed
the
refactor/install-opts-cleanup
branch
from
July 14, 2026 08:03
de49ea3 to
968c655
Compare
This comment has been minimized.
This comment has been minimized.
rami3l
force-pushed
the
refactor/install-opts-cleanup
branch
from
July 18, 2026 09:12
968c655 to
920b18c
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
rami3l
force-pushed
the
refactor/install-opts-cleanup
branch
from
July 20, 2026 08:12
920b18c to
a74234d
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
djc
reviewed
Jul 21, 2026
rami3l
force-pushed
the
refactor/install-opts-cleanup
branch
2 times, most recently
from
July 22, 2026 19:14
45621e8 to
64fda73
Compare
Member
Author
|
@djc I see that this patch is still not approved. Do you have any more concerns or can I merge it now? Thanks :) |
djc
approved these changes
Jul 23, 2026
…llOpts::select_toolchain()`
…Opts::install_rust()`
rami3l
force-pushed
the
refactor/install-opts-cleanup
branch
from
July 23, 2026 09:14
64fda73 to
1faac27
Compare
rami3l
enabled auto-merge
July 23, 2026 09:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #4947 (comment) and #4947 (comment).