Repository navigation
fix(diskio): stop warn!()ing in get_executor() - #5198
Merged
Merged
Conversation
rami3l
force-pushed
the
test/ram-budget-snapshot
branch
from
November 7, 2026 08:54
f3f570c to
c66c865
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
djc
approved these changes
Nov 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #5194.
GitHub seems to be silently downgrading the experience on macOS runners by lowering available RAM. This is not always the case, but when it triggers, rustup emits this warning and the snapshots get messed up:
This is only possible when the branch in L500 is triggered without also triggering the
error!()call (minimum_ramis set to exactly 32MiB):rustup/src/diskio/mod.rs
Lines 490 to 505 in 71668d2
... which means the available RAM is less than 200MiB. Please note that this only happens to macOS runners; Windows and Linux runners don't have this problem.
I think this
warn!()message is still valuable, but don't think it can be that interesting to the user in such circumstances, so I downgraded it fromwarn!()todebug!().