Simplify scalable vector testing#2188
Open
sayantn wants to merge 1 commit into
Open
Conversation
sayantn
force-pushed
the
intrinsic-test-refactors
branch
2 times, most recently
from
4207270 to
f3f413d
Compare
sayantn
force-pushed
the
intrinsic-test-refactors
branch
from
f3f413d to
6986e10
Compare
sayantn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
svbool_t, keep using just XOR and compare to 0 (because the repr is NOT just a contiguous array ofbools)svint8_t, we can convert&svint8_tsafely to&[i8]with lengthsvcntb()This approach seems to work nicely, at least for now (it was indeed failing a few days ago, maybe some LLVM update fixed it recently)
r? @davidtwco