Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/app-sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ export function AppSidebar() {
const dir = useDirection()
const brandInitial = APP_NAME.charAt(0).toUpperCase() ?? "R"

const { isAdmin, canAccessPath, hasResolvedAdmin, hasFetchedPolicy, isLoading } = usePermissions()
const { isAdmin, canAccessPath, hasResolvedAdmin, hasFetchedPolicy } = usePermissions()
const { route: homeRoute } = useFirstAccessibleDashboardRoute()
const isPermissionsReady = hasResolvedAdmin && (isAdmin || (!isLoading && hasFetchedPolicy))
const isPermissionsReady = hasResolvedAdmin && (isAdmin || hasFetchedPolicy)

if (!isPermissionsReady) {
return null
Expand Down
21 changes: 6 additions & 15 deletions components/dashboard-auth-guard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export function DashboardAuthGuard({ children }: { children: React.ReactNode })
const { isAuthenticated } = useAuth()
const { isReady: apiReady } = useApiReady()
const { isReady: s3Ready } = useS3Ready()
const { isAdmin, isLoading, hasFetchedPolicy, hasResolvedAdmin, canAccessPath } = usePermissions()
const { isAdmin, hasFetchedPolicy, hasResolvedAdmin, canAccessPath } = usePermissions()

const isReady = apiReady && s3Ready

Expand All @@ -29,23 +29,14 @@ export function DashboardAuthGuard({ children }: { children: React.ReactNode })

useEffect(() => {
if (!isReady || !isAuthenticated || !hasResolvedAdmin) return
if (!isAdmin && (isLoading || !hasFetchedPolicy)) return
if (!isAdmin && !hasFetchedPolicy) return
if (!canAccessDashboardRoute(pathname, { isAdmin, canAccessPath })) {
router.replace("/403/")
}
}, [
isReady,
isAuthenticated,
hasResolvedAdmin,
isAdmin,
isLoading,
hasFetchedPolicy,
canAccessPath,
pathname,
router,
])

if (!isReady || !isAuthenticated || !hasResolvedAdmin || (!isAdmin && (isLoading || !hasFetchedPolicy))) {
}, [isReady, isAuthenticated, hasResolvedAdmin, isAdmin, hasFetchedPolicy, canAccessPath, pathname, router])

// Background refreshes must not unmount the page that requested them.
if (!isReady || !isAuthenticated || !hasResolvedAdmin || (!isAdmin && !hasFetchedPolicy)) {
return (
<div role="status" className="flex min-h-64 items-center justify-center gap-3 text-sm text-muted-foreground">
<Spinner className="size-5" />
Expand Down
4 changes: 2 additions & 2 deletions hooks/use-first-accessible-dashboard-route.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import { getFirstAccessibleDashboardRoute } from "@/lib/dashboard-route-meta"

export function useFirstAccessibleDashboardRoute() {
const { isAuthenticated } = useAuth()
const { isAdmin, canAccessPath, hasFetchedPolicy, hasResolvedAdmin, isLoading } = usePermissions()
const { isAdmin, canAccessPath, hasFetchedPolicy, hasResolvedAdmin } = usePermissions()

const isReady = isAuthenticated && hasResolvedAdmin && (isAdmin || (!isLoading && hasFetchedPolicy))
const isReady = isAuthenticated && hasResolvedAdmin && (isAdmin || hasFetchedPolicy)

const route = useMemo(() => {
if (!isReady) return null
Expand Down
Loading