Reject invalid user guide PDF downloads - #18
Draft
magrathean-uk wants to merge 1 commit into
Draft
magrathean-uk wants to merge 1 commit into
magrathean-uk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release artifact step currently accepts an HTML error page as
rustic-user-docs.pdf. Make the download fail on HTTP errors and reject a payload without the PDF signature before packaging it.Related issue: rustic-rs/rustic#1893
Depends on rustic-rs/docs#147, which restores the PDF at the published URL. This PR is a draft while the live URL returns 404.
Validation:
action.ymlparsed with PyYAML, the download and signature guard were checked in the workflow, andgit diff --checkpassed. A full release workflow cannot succeed until the docs change is deployed.