refactor: clarify reconnect-related naming

[quettabit]

No description provided.

[greptile-apps]

Greptile Summary

This PR clarifies reconnect-related naming and makes advised-reconnect acquisition atomically record against the limiter.

• Renames reconnect thresholds, outcomes, events, and local variables to distinguish server-advised reconnects.
• Combines the limiter check and recording operation so errors after accepted advice cannot bypass reconnect throttling.
• Updates both append and read session callers consistently.

Confidence Score: 5/5

The PR appears safe to merge; the previous reconnect-limiter bypass is resolved and no new actionable failures were found.

The limiter now records an accepted reconnect advice in the same operation that authorizes it, preventing retryable errors from opening an uncounted replacement connection. The previous finding was manually resolved, and the current implementation fully addresses its described failure mode.

Important Files Changed

Filename	Overview
src/s2_sdk/_retrier.py	Renames reconnect thresholds and replaces the predicate with an atomic acquire-and-record operation.
src/s2_sdk/_s2s/_append_session.py	Adopts advised-reconnect terminology and uses atomic limiter acquisition before draining and reconnecting.
src/s2_sdk/_s2s/_read_session.py	Updates read-session reconnect handling to use the atomic limiter operation consistently.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Server advises reconnect] --> B{Limiter permits advice?}
    B -->|No| C[Continue current session]
    B -->|Yes| D[Atomically record reconnect]
    D --> E[Drain or deliver pending data]
    E --> F{Session complete?}
    F -->|Yes| G[Return]
    F -->|No| H[Reconnect]

Loading

_{Reviews (2): Last reviewed commit: "restore single op that checks and record..." | Re-trigger Greptile}