Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/s2_sdk/_s2s/_append_session.py
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,10 @@ async def _run_attempt(
)
if advised_reconnect.is_set():
return _AttemptOutcome.RECONNECT_ADVISED
if not session_state.inputs_exhausted:
raise S2ClientError(
"Append session response stream closed before the input source was exhausted"
)
return _AttemptOutcome.COMPLETE


Expand Down
10 changes: 7 additions & 3 deletions tests/test_append_session.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def decoded_messages(stream: AsyncIterator[bytes]) -> AsyncIterator[Message]:

attempts = [
((_ack(0, reconnect_advised=True), _ack(1)), 2),
((), 0),
((), None),
]
responses: list[_Response] = []

Expand All @@ -59,8 +59,12 @@ async def streaming_request(
) -> AsyncGenerator[_Response, None]:
messages, inputs_to_consume = attempts.pop(0)
if content is not None:
for _ in range(inputs_to_consume):
await content.__anext__()
if inputs_to_consume is None:
async for _ in content:
pass
else:
for _ in range(inputs_to_consume):
await content.__anext__()
response = _Response(messages)
responses.append(response)
try:
Expand Down
Loading