Skip to content

fix: incorrect tracking of usable conns in reaper #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quettabit merged 1 commit into from
Sep 13, 2026
Merged

fix: incorrect tracking of usable conns in reaper #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/s2_sdk/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,9 @@ async def _reap_idle(self) -> None:
await asyncio.sleep(REAPER_INTERVAL)
empty_hosts: list[str] = []
for base_url, conns in tuple(self._hosts.items()):
num_usable_conns = sum(
not pc.is_retired and pc._conn.is_available for pc in conns
)
to_close: list[_PooledConnection] = []
for pc in conns:
if pc.is_retired:
Expand All @@ -444,9 +447,10 @@ async def _reap_idle(self) -> None:
elif (
pc.is_idle
and pc.idle_for() > IDLE_TIMEOUT
and len(conns) - len(to_close) > 1
and num_usable_conns > 1
):
to_close.append(pc)
num_usable_conns -= 1
for pc in to_close:
conns.remove(pc)
for pc in to_close:
Expand Down
Loading