Repository navigation
fix(builtin): raise Go runtime panics for channel and nil map faults - #535
Merged
Merged
Conversation
A negative channel size, a send on or close of a closed channel, and an assignment to a nil map threw plain JavaScript Errors, which recover does not see as Go panics. They now panic with the runtime.Error values and messages of Go: makechan: size out of range, send on closed channel, close of closed channel, and assignment to entry in nil map. Signed-off-by: Randall C. O'Reilly <oreilly@ucdavis.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A negative channel size, a send on or close of a closed channel, and an assignment to a nil map threw plain JavaScript Errors. recover does not see those as Go panics, so code that recovers from these faults failed: for example a Go interpreter that captures the runtime's panic values at init, by making a channel with a negative size inside a recover, crashed at startup.
They now panic with runtime.Error values carrying the messages of Go: makechan: size out of range, send on closed channel, close of closed channel, and assignment to entry in nil map. A send that is waiting when the channel is closed is rejected with the same panic. The builtin panic tests cover each case, and the net/http test of a nil Header expects the Go message.