Repository navigation
feat(runtime): add PanicNilError and register runtime.Error - #536
Merged
Merged
Conversation
runtime.PanicNilError was a stub that panicked when constructed, so code that names it, such as an interpreter that mirrors panic(nil), failed at init. It now has the Error and RuntimeError methods of Go. runtime.Error was not registered with the runtime type system, so a type assertion to it never succeeded. It is now registered, and recovered runtime panics have the RuntimeError method, so they satisfy it as in Go. Signed-off-by: Randall C. O'Reilly <oreilly@ucdavis.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runtime.PanicNilError was a generated stub that panicked when constructed, so a package that names it at init (an interpreter that mirrors panic(nil), for example) failed to start. It now has the Error and RuntimeError methods of Go and the message of Go 1.27.
runtime.Error was not registered with the runtime type system, so a type assertion to it never succeeded, even for a recovered index out of range. It is now registered, and the RuntimeError value of a recovered runtime panic has the RuntimeError method, so it satisfies runtime.Error as in Go. package_import_runtime checks both.