Repository navigation
fix(builtin): wrap a uint64 converted to int in generic code - #537
Merged
Merged
Conversation
A conversion to a type parameter whose type argument is int did not wrap a uint64 beyond the int range, so T(u) for u = 1<<64 - 7 gave 18446744073709552000 instead of -7, as the non-generic int(u) does. Signed-off-by: Randall C. O'Reilly <oreilly@ucdavis.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A conversion to a type parameter whose type argument is int, T(u), did not wrap a uint64 beyond the int range: for u = 1<<64 - 7 it gave 18446744073709552000 instead of -7, which the non-generic int(u) gives. genericConvert now converts to int with 64 bits, as it does for uint.
This broke code that keeps integers as uint64 bits and converts them back with generic helpers, such as the arithmetic of a bytecode interpreter: -7 % 3 gave 1. generic_typeparam_conversion covers int, int64 and int32.