Repository navigation
feat: deliver model request headers on beta - #52
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6820ed0dc4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| api_key: string; | ||
| base_url: string; | ||
| context_window?: number; | ||
| headers?: Headers | null; |
There was a problem hiding this comment.
Forward model headers through the public TypeScript client
Although the generated schema now declares headers, @oac/agents-client exports its handwritten ModelProviderInput from src/types.ts, where this property is absent, and AdminClient.setHarnessModelConfiguration reconstructs model_provider without copying it. Consequently TypeScript callers cannot supply headers normally, and even a JavaScript caller that passes them has them silently discarded before the deployment-default request, so the advertised header delivery does not work through the supported client. Update the exported type and the admin request serializer alongside this generated projection.
AGENTS.md reference: AGENTS.md:L24-L24
Useful? React with 👍 / 👎.
为当前 beta 安装增加 model_provider.headers,随冻结会话传递到 Codex、Claude 和 MiniMax 的模型请求,支持非敏感活动标识。保留 beta 原有诊断、input receipts、流控及 Runtime 生命周期行为。
移植已审查的 #51 两个提交,唯一冲突为中文文档来源摘要。完整差异与契约保留性已独立复核;契约生成检查、Go 测试、Core 测试编译、三原生 SDK/CLI 本地请求捕获及 Claude TypeScript 测试通过。
需 CI 通过后配套发布 Core/Web 和同 SHA 的 creative Runtime 模板。实际部署与真实模型接收日志尚未验收;无计费逻辑或 DDL。