Repository navigation
Log credential verification failure phases - #53
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployment credential verification currently returns the same ownership error without identifying whether the committed selection, candidate, retained generation or allocation references failed. Emit one structured failure log with a fixed phase and error class, numeric generation and reference count so operators can locate the failing verification step.
The change preserves verification order, ownership checks and API error mapping. It logs no raw errors, credentials, configuration, template or endpoint. English and Chinese deployment documentation describe the diagnostic fields.
Validation: full
go test ./services/core/cmd/serverpasses, including fixture checks for each verification/read failure phase, unchanged returned errors, no private values, and no failure log on success. Independent review and focused tests passed; translation hash and diff checks passed. No production deployment or live provider calls were performed for this patch.