Repository navigation
Scope retained-resource verification to credential access changes - #54
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template or resource updates currently revalidate every retained build and sandbox reference even when the credential and connection selectors are unchanged. An unrelated retained-resource failure or the shared verification deadline can therefore block a new Runtime template.
Keep the committed ownership anchor and candidate template/build verification for every update. When no credential was explicitly submitted and the adapter confirms identical normalized credential access, omit the retained-generation/reference scan. Explicit credential submissions (including the same key), key differences, API URL changes and domain changes retain the full scan. Credential replacement fencing and its final verification, immutable generation routing, and failure preservation are unchanged.
The provider-neutral
CredentialAccessEqualconfiguration contract owns comparison; no E2B fields are interpreted by Core. English and Chinese protocol documentation describe the admission rule.Validation: affected server, E2B, execution, deployment and provider package tests; Go vet for server and sandbox packages; translation freshness/routes; focused cases for template/resources, explicit same/replacement key, API URL/domain changes, rejected anchor/candidate ownership and invalid candidate build. Independent review and its separate focused test run passed. No production deployment or live Runtime activation is part of this PR's validation.