Repository navigation
feat(directive-rich-media): add placeholder media assets so the demo renders - #17
Merged
Merged
Conversation
|
✅ No issues found Checked c3b3cc9 • notify-only, does not block merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
directive-rich-mediademo references 8 media assets (screenshots, a compare pair, an architecture diagram, an icon, an asciinema cast) that never existed in the repo — the directory held onlydirective-rich-media.md. Every image 404'd (the intro Note called them "illustrative placeholders … Supply your own assets").This adds labeled placeholder stand-ins under the exact referenced names so the demo renders cleanly instead of broken-image icons. Replace with real BTP Cockpit screenshots / diagram / cast when available.
Assets added
cockpit-global-account.png,cockpit-subaccount-detail.png,cockpit-space-apps.png— labeled 1440×810 placeholders (standard![]()images)cf-login-first-time.png,cf-login-cached-token.png— the::comparebefore/after paircap-cf-architecture.svg— a real, simple architecture diagram SVG (::diagram)icon-goto-subaccount.png— inline:imageiconmbt-build-and-deploy.cast— a minimal valid asciinema v2 cast (::cast)All are clearly watermarked "placeholder — replace with real …".
Note
This unblocks the demo visually. It pairs with tutorials-ims fixes for the directive image-proxy path and the prereq-card title/time; those are separate PRs in that repo.