Repository navigation
fix(release): pass on a retried command's output and its retry warning as they come - #273
Merged
Merged
Conversation
…g as they come In the workflow, the script's stdout is a pipe, which Python holds until its buffer fills: a build's lines came through in bursts, and the warning that a rate-limited command would be tried again could stay hidden through the wait, so the job looked stuck. Each forwarded line and each warning is flushed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A follow-up to #272. In the release workflow,
infra_build.py's stdout is a pipe, which Python holds until its buffer fills. So a build's lines came through in bursts, and the "trying again in 30s" warning could stay hidden through the whole wait, making the job look stuck. Greptile raised it on #272 after it merged._streamednow flushes after each line it forwards, and the retry warning is printed withflush=True.How it was tested
A new unit test stands in a pipe for stdout and checks that the rate-limited output, the warning and each later line are each flushed as they're written.
test_infra_build_script.pyandtest_release_infra_images.pypass (56).🤖 Generated with Claude Code
This PR appears safe to merge.Summary
Makes release logs appear promptly when stdout is a pipe.
Reviews (1) · Last reviewed commit: "fix(release): pass on a retried command'..." · Reviewed by Greptile