Skip to content

fix(release): pin the protocol in the shipped bundles in the CodeArtifact publish too #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
earakely-scale merged 1 commit into from
Oct 22, 2026
Merged

fix(release): pin the protocol in the shipped bundles in the CodeArtifact publish too #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ jobs:
sed -i "s/\"agentenv-framework-protocol[^\"]*\"/\"agentenv-framework-protocol==${PV}\"/" pyproject.toml
python -c "import tomllib; tomllib.load(open('pyproject.toml','rb'))"
grep -q "\"agentenv-framework-protocol==${PV}\"" pyproject.toml
# The shipped bundles' requirements too, as the PyPI release does, or this wheel's agents install a floor.
python .github/scripts/shipped_bundles.py pin
python -m build

- run:
Expand Down
7 changes: 7 additions & 0 deletions tst/unit/test_release_protocol_pins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,13 @@ def test_the_release_pins_the_shipped_bundles_with_the_script():
assert "requirements_files=$(" not in WORKFLOW


def test_the_codeartifact_release_pins_the_shipped_bundles_before_it_builds_the_wheel():
publish = (REPO / ".circleci" / "config.yml").read_text().split("\n publish:\n", 1)[1]
build = publish.index(" python -m build\n")

assert -1 < publish.find(".github/scripts/shipped_bundles.py pin") < build


def test_each_shipped_requirements_file_the_release_pins_holds_one_protocol_line():
pinned = {path.relative_to(REPO).as_posix(): [line for line in path.read_text().splitlines()
if line.startswith("agentenv-framework-protocol")]
Expand Down
Loading