feat: model create/edit parity with the dashboard UI [DE-8691] - #481
Draft
luke-e-schaefer wants to merge 1 commit into
Draft
feat: model create/edit parity with the dashboard UI [DE-8691]#481luke-e-schaefer wants to merge 1 commit into
luke-e-schaefer wants to merge 1 commit into
Conversation
Brings SDK model create/edit to parity with the Nucleus dashboard. Previously
create_model() only sent name/reference_id/metadata/bundle_name/tags/
trained_slice_ids and there was no edit path at all.
- create_model(): adds description, architecture, num_parameters, training_data,
input_schema, output_schema, structured training_data_fields ({key: value},
merged into metadata under the reserved key + indexed for search), and
versioning (parent_model_project_id, bump_type, version_major/minor, version_label).
The REST models/add endpoint already accepted all of these.
- NucleusClient.update_model() / Model.update(): edit descriptive fields via the new
POST /nucleus/model/:modelId/update endpoint (scaleapi companion PR). NO_UPDATE
sentinel distinguishes "leave unchanged" from an explicit None ("clear").
- Model.set_parent(): set/clear parent + version via the existing .../parent route.
- Model gains description/architecture/num_parameters/training_data/input_schema/
output_schema/parent_model_project_id/version_major/minor/version_label, populated
by from_json (which now also reads bundle_name and falls back ref_id -> reference_id).
- Version bump 0.21.3 + CHANGELOG.
Backend companion: scaleapi luke/nucleus-model-rest-update-parity.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Backend companion PR: scaleapi/scaleapi#158730 · Tracking: DE-8691 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the SDK's model create and edit to full parity with the Nucleus dashboard. Previously
create_model()only sentname/reference_id/metadata/bundle_name/tags/trained_slice_ids, and there was no edit path at all.Part of DE-8691. Backend companion: scaleapi branch
luke/nucleus-model-rest-update-parity.What changed
create_model()now accepts every field the UI exposes:description,architecture,num_parameters,training_data,input_schema,output_schema, structuredtraining_data_fields({key: value}, merged intometadataunder the reserved key and indexed for search), and versioning (parent_model_project_id,bump_type,version_major,version_minor,version_label). The RESTmodels/addendpoint already accepted all of these.NucleusClient.update_model()/Model.update()— edit descriptive fields via the newPOST /nucleus/model/:modelId/updateendpoint (backend PR). ANO_UPDATEsentinel distinguishes "leave unchanged" from an explicitNone("clear").Model.set_parent()— set/clear parent + version via the existing.../parentroute.Modelgainsdescription/architecture/num_parameters/training_data/input_schema/output_schema/parent_model_project_id/version_major/version_minor/version_label, populated byfrom_json(which now also readsbundle_nameand falls backref_id→reference_id).0.21.3+ CHANGELOG.Testing
tests/test_models.pyhit the live API (needNUCLEUS_API_KEY); the new edit/create-field coverage is TODO before marking ready. Ranblack/isort+py_compilelocally.🤖 Generated with Claude Code