feat(cli): stamp global.agent.version from the image tag on helm deploys - #504
Open
max-parke-scale wants to merge 1 commit into
Open
feat(cli): stamp global.agent.version from the image tag on helm deploys#504max-parke-scale wants to merge 1 commit into
max-parke-scale wants to merge 1 commit into
Conversation
With agentex-agent chart >=0.6.0 (sgp#5466) the value lands as the pod's AGENT_VERSION, which the SGP tracing processor stamps onto every span as __agent_version__. Old charts ignore the key, so ordering is free. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI (classic helm) deploys now set
global.agent.versionto the resolved image tag in the rendered helm values. With agentex-agent chart ≥ 0.6.0 (scaleapi/sgp#5466) that lands as the pod'sAGENT_VERSIONenv var, which the SGP tracing processor (agentex-sdk ≥ 0.25.0, #469) stamps onto every span as__agent_version__— build provenance on traces, keyed by the same image identity the lineage build/deploy graph uses.Ordering is free in both directions: old charts ignore the key; the new chart omits the env var when the key is absent. Siblings: chart = scaleapi/sgp#5466; agentex cloud deploy = scaleapi/scaleapi#158940. Set the version via the image tag here or an explicit
AGENT_VERSIONin manifestenv, not both — repeating a chart-generated name renders duplicate env entries.🧑💻🤖 — posted via Claude Code
Greptile Summary
The PR adds the resolved deployment image tag to
global.agent.versionin generated classic Helm values so compatible charts can expose it as trace provenance.global.image.tag.Confidence Score: 4/5
The PR appears safe to merge, with a non-blocking gap in regression coverage for the new Helm-value output.
The generated version uses the same validated image tag as the deployed image, while the only accepted concern is that no deployment-handler test protects this new producer-side contract.
Files Needing Attention: src/agentex/lib/cli/handlers/deploy_handlers.py
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "feat(cli): stamp global.agent.version fr..." | Re-trigger Greptile