Skip to content

feat(cli): stamp global.agent.version from the image tag on helm deploys - #504

Open
max-parke-scale wants to merge 1 commit into
nextfrom
mparke/agent-version-cli-deploy
Open

feat(cli): stamp global.agent.version from the image tag on helm deploys#504
max-parke-scale wants to merge 1 commit into
nextfrom
mparke/agent-version-cli-deploy

Conversation

@max-parke-scale

@max-parke-scale max-parke-scale commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

CLI (classic helm) deploys now set global.agent.version to the resolved image tag in the rendered helm values. With agentex-agent chart ≥ 0.6.0 (scaleapi/sgp#5466) that lands as the pod's AGENT_VERSION env var, which the SGP tracing processor (agentex-sdk ≥ 0.25.0, #469) stamps onto every span as __agent_version__ — build provenance on traces, keyed by the same image identity the lineage build/deploy graph uses.

Ordering is free in both directions: old charts ignore the key; the new chart omits the env var when the key is absent. Siblings: chart = scaleapi/sgp#5466; agentex cloud deploy = scaleapi/scaleapi#158940. Set the version via the image tag here or an explicit AGENT_VERSION in manifest env, not both — repeating a chart-generated name renders duplicate env entries.

🧑‍💻🤖 — posted via Claude Code

Greptile Summary

The PR adds the resolved deployment image tag to global.agent.version in generated classic Helm values so compatible charts can expose it as trace provenance.

  • Uses the same resolved tag already assigned to global.image.tag.
  • Preserves compatibility with charts that ignore the new value.
  • Lacks direct deployment-handler coverage for the generated field and its override precedence.

Confidence Score: 4/5

The PR appears safe to merge, with a non-blocking gap in regression coverage for the new Helm-value output.

The generated version uses the same validated image tag as the deployed image, while the only accepted concern is that no deployment-handler test protects this new producer-side contract.

Files Needing Attention: src/agentex/lib/cli/handlers/deploy_handlers.py

Important Files Changed

Filename Overview
src/agentex/lib/cli/handlers/deploy_handlers.py Adds the resolved image tag to the Helm agent metadata correctly, but does not add a focused test for the new rendered-values contract.

Fix all with Greploop Fix All in Cursor Fix All in Claude Code Fix All in Codex

Prompt To Fix All With AI
### Issue 1
src/agentex/lib/cli/handlers/deploy_handlers.py:284
**Version propagation lacks coverage**

The new `global.agent.version` output has no deployment-handler test asserting that it matches the resolved image tag, including CLI override precedence. A later change to tag resolution or Helm-value merging can therefore silently break trace provenance without a focused test detecting it.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "feat(cli): stamp global.agent.version fr..." | Re-trigger Greptile

With agentex-agent chart >=0.6.0 (sgp#5466) the value lands as the pod's
AGENT_VERSION, which the SGP tracing processor stamps onto every span as
__agent_version__. Old charts ignore the key, so ordering is free.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant