Conversation
The bundled default.pptx carried a hard-coded personal name in cp:lastModifiedBy of docProps/core.xml, so every presentation created with Presentation() and saved kept that name as "last modified by". - set cp:lastModifiedBy to "python-pptx" - refresh dcterms:created / dcterms:modified from their 2013 values - add a test asserting no personal name appears in the default core.xml - add an Unreleased entry to HISTORY.rst
RyoKakomi
marked this pull request as ready for review
September 30, 2026 04:36
RyoKakomi
marked this pull request as draft
September 30, 2026 04:36
RyoKakomi
marked this pull request as ready for review
September 30, 2026 04:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1149
Problem
The bundled
default.pptxships adocProps/core.xmlwhosecp:lastModifiedByis hard-coded toSteve Canny, with timestamps from2013. Since
Package.core_propertiesreturns the existing part as-is andCorePropertiesPart.default()only runs when the part is missing, everypresentation created with
Presentation()and saved carries that name as"Last Modified By".
Changes
docProps/core.xmlinsidesrc/pptx/templates/default.pptx:cp:lastModifiedByis nowpython-pptx(matchingCorePropertiesPart.default()), anddcterms:created/dcterms:modifiedare refreshed.dc:creatorstays empty. All otherzip entries are copied unchanged, preserving order and compression.
tests/test_api.pythat loads the default template andasserts no personal name appears in its core properties.
HISTORY.rst.Verification
pytest: 2701 passedbehave --tags=-wip: 973 scenarios passedPresentation()and confirmed<cp:lastModifiedBy>python-pptx</cp:lastModifiedBy>and an empty<dc:creator/>in the output.Note: the test suite currently fails collection on pytest 9 because of
PytestRemovedIn10Warning(class-scoped fixtures as instance methods),which is unrelated to this change. I ran with that warning ignored.