Repository navigation
Fix wire-completion targeting and owned sheet observation - #953
Merged
Merged
Conversation
Bind the planned source and target before launch, reacquire stable safe geometry, and observe owned sheet hosts plus native children. Record PMv2 posted-pointer receipts and keep action failures distinct from cleanup failures. Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair W1's unsafe card targeting and false-negative native-form observer without changing the product or retrying the stopped action attempt. A posted target click now has an explicit source/target plan, a source-derived safe region, owned sheet/child observation, and diagnostic receipts that distinguish harness refusal from product behavior.
Changes
Test plan
RED: pwsh -NoProfile -File C:\w1r\baseline\Tools\windows\Tests\WireTargeting.Tests.ps1 -ScratchRoot C:\w1r\red-corrected -LegacyBehavior -> 2 executed, 2 expected failures: Top-level-only oracle missed the owned child content; Card midpoint hits Mark as entry before generic node selection.
GREEN: pwsh -NoProfile -File Tools\windows\Tests\WireTargeting.Tests.ps1 -ScratchRoot C:\w1r\green-final -> 56 executed, 56 passed, 0 failed, 0 skipped on the clean committed source.
REGRESSION: pwsh -NoProfile -File Tools\windows\Tests\ValidationRunner.Tests.ps1 -> PASS; UiScenario 166/166, UiCaptureDriver 182/182, ActionWorkerImport 18/18, ActionWindowIdentity 62/62, ActionTopologyImport 16/16, WireTargeting 56/56; all reported suite skips 0.
The corrected RED uses the unchanged original driver exported from ec1ad74, Git blob 95e0f9820933c7ebbcbf369fda54cf828b70dc71. The initial RED was recorded before implementation, but its oracle fixture also had a
STATIC/Staticcasing confound; only its midpoint failure was clean. The corrected two-case baseline run was obtained afterward. Both logs remain preserved, and the test-first checklist item is deliberately unchecked rather than overstating chronology.Earlier failed implementation runs, a stopped partial runner, and the real-zmx stale-fixture source-hash refusal remain separate from passing output. The latter was a setup refusal, not evidence of product behavior.
Additional pinned real-zmx regression: 185 executed, 185 passed, 0 failed, 0 skipped, with newly generated, source-bound fixtures:
pwsh -NoProfile -File Tools\windows\validate.ps1 -Task hardeningpassed all three deterministic repetitions; the optional product environment/hardware matrix was not run.pwsh -NoProfile -File Tools\windows\validate.ps1 -Task privacy, nine-file PowerShell parsing,git diff --check, andTools\tdd\Test-TddEvidence.ps1 -BodyPathpassed.The native fixture is a harmless owned popup/child hierarchy, not GraphCode or a provider campaign. Production DryRun uses only the existing contained harmless
pwshchild; its algorithm fixture is model-only. No W1-W6 product retry, screenshots, C8R captures, product source changes, or parity-ledger promotions.The actual clean-head production entry DryRun passed at commit
6dd6556bb7cf85dcf8bf06d87cd1c1106144ad1c, tree6f2a1354ecd848ca834bf28628bd48674d3de116: six source/window bindings, three imported helpers, five prepared topology plans, and the shared safe-target/owned-child model preflight, with zero GraphCode/provider campaign launch. Proof:C:\w1r\production-head\production-entry-evidence.json, SHA25644C8F208D69BF8CA3DB88DD29068B2BB411F342821328C0657B41EBE3B05ABCF. This is not a live W1 action result or target-private EOF proof.macOS
make test/make check, live GraphCode behavior, and live W1-W6 parity were not run. Windows fixture tests and posted-message acceptance do not establish native physical input, glyphs, persistence, or parity. The stopped action attempt remains stopped and unreconstructed.Checklist
git commit -s) per the DCOmake test)make check)