Preserve iterable middleware arguments#569
Draft
claell wants to merge 1 commit into
Draft
Conversation
* Materialize one-shot middleware iterables before duplicate checks. * Exercise parse and unparse iterator inputs through the public API. * Correct unparse duplicate-warning terminology.
claell
force-pushed
the
fix/531-preserve-iterable-middleware
branch
from
7bcff02 to
464778f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
append_middlewareandprepend_middlewareiterablesbefore checking their types.
Fixes #531.
Validation
deprecation warnings in
tests/test_entrypoint.py.git diff --check: passed.environment; GitHub CI should independently run the configured hooks.
Review note
This change was developed and validated in a concentrated session rather than
exercised over a long period in production. It has focused public-API regression
coverage, but careful human review of the implementation and assumptions is
requested.
AI assistance
This pull request was prepared with ChatGPT Codex using GPT-5.6 Sol with high
reasoning effort. Codex assisted with analysis, implementation, branch
isolation, and test execution. Automated validation is not a substitute for
maintainer review.