Preserve trailing backslashes in name round trips#573
Draft
claell wants to merge 1 commit into
Draft
Conversation
* Avoid duplicating a terminal backslash while splitting names. * Escape comma-adjacent name sections without changing the final section. * Enable the strict and non-strict inverse regressions.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
of input.
skipping names with odd trailing backslashes.
Fixes #567.
Validation
deprecation warnings in
tests/test_entrypoint.py. The two removed skips arethe now-passing strict and non-strict inverse cases.
git diff --check: passed.environment; GitHub CI should independently run the configured hooks.
Review note
This change was developed and validated in a concentrated session rather than
exercised over a long period in production. The broad existing name fixture
matrix now passes without the targeted skip, but careful human review of TeX
escaping semantics is requested.
AI assistance
This pull request was prepared with ChatGPT Codex using GPT-5.6 Sol with high
reasoning effort. Codex assisted with analysis, implementation, branch
isolation, and test execution. Automated validation is not a substitute for
maintainer review.