Exercise enclosure-like values without skipped tests#580
Draft
claell wants to merge 1 commit into
Draft
Conversation
* Assert exact output when unwrapped values resemble enclosed syntax. * Cover removal metadata and no-enclosing behavior across the full matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
removed_enclosingmetadata across the full matrix.no-enclosing.Closes #579.
Validation
pytest -p no:cacheprovider -W error tests/middleware_tests/test_enclosing.py: 926 passed, with no skips.tests/test_entrypoint.py.Review note
This is a test-only change. The key judgment is that values beginning and ending with enclosure characters remain valid cases to test: removal interprets those boundary characters as enclosure, while addition configured with
no-enclosingadds nothing and should be checked by exact equality.AI assistance
This pull request was prepared with ChatGPT Codex using GPT-5.6 Sol with high reasoning effort. Codex assisted with test-matrix analysis, branch isolation, and validation. Automated validation is not a substitute for maintainer review.