Skip to content

Capture expected deprecation warnings in entry-point tests #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
claell wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −8
Draft

Capture expected deprecation warnings in entry-point tests #582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions tests/test_entrypoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,9 @@ def test_write_file_both_parse_stack_and_unparse_stack_raises_error():
temp_path = f.name

try:
with pytest.raises(ValueError) as excinfo:
write_file(temp_path, library, parse_stack=[], unparse_stack=[])
with pytest.warns(DeprecationWarning):
with pytest.raises(ValueError) as excinfo:
write_file(temp_path, library, parse_stack=[], unparse_stack=[])
assert "parse_stack" in str(excinfo.value)
assert "unparse_stack" in str(excinfo.value)
assert "Use 'unparse_stack' instead" in str(excinfo.value)
Expand All @@ -160,8 +161,9 @@ def test_write_file_both_append_and_prepend_middleware_raises_error():
temp_path = f.name

try:
with pytest.raises(ValueError) as excinfo:
write_file(temp_path, library, append_middleware=[], prepend_middleware=[])
with pytest.warns(DeprecationWarning):
with pytest.raises(ValueError) as excinfo:
write_file(temp_path, library, append_middleware=[], prepend_middleware=[])
assert "append_middleware" in str(excinfo.value)
assert "prepend_middleware" in str(excinfo.value)
assert "Use 'prepend_middleware' instead" in str(excinfo.value)
Expand Down Expand Up @@ -215,8 +217,9 @@ def test_write_string_both_parse_stack_and_unparse_stack_raises_error():
"""Test that providing both parse_stack and unparse_stack raises ValueError."""
library = Library([])

with pytest.raises(ValueError) as excinfo:
write_string(library, parse_stack=[], unparse_stack=[])
with pytest.warns(DeprecationWarning):
with pytest.raises(ValueError) as excinfo:
write_string(library, parse_stack=[], unparse_stack=[])
assert "parse_stack" in str(excinfo.value)
assert "unparse_stack" in str(excinfo.value)
assert "Use 'unparse_stack' instead" in str(excinfo.value)
Expand All @@ -226,8 +229,9 @@ def test_write_string_both_append_and_prepend_middleware_raises_error():
"""Test that providing both append_middleware and prepend_middleware raises ValueError."""
library = Library([])

with pytest.raises(ValueError) as excinfo:
write_string(library, append_middleware=[], prepend_middleware=[])
with pytest.warns(DeprecationWarning):
with pytest.raises(ValueError) as excinfo:
write_string(library, append_middleware=[], prepend_middleware=[])
assert "append_middleware" in str(excinfo.value)
assert "prepend_middleware" in str(excinfo.value)
assert "Use 'prepend_middleware' instead" in str(excinfo.value)
Expand Down
Loading