Recognize complete BibTeX block starts#584
Draft
claell wants to merge 4 commits into
Draft
Conversation
* Preserve unsupported entry, string, preamble, and comment source as explicit failures. * Recover subsequent supported blocks on the same or following line.
Treat custom entry types that extend comment, preamble, or string names as ordinary entries.
* Accept standard whitespace before outer delimiters. * Preserve punctuation permitted in entry-type identifiers. * Keep line-separated parenthesis blocks visible as explicit failures.
Require every standard-delimited block candidate to become either a parsed entry or an explicit failed block across whitespace and identifier variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #583.
Dependency and commit structure
This draft currently includes the exact prerequisite behavior from:
@comment,@preamble, and@string.Those behaviors remain separate as the first two commits. The issue #583 implementation and its exhaustive visibility matrix are the final two commits. The branch is executable against current
main; once the prerequisites merge, it should be rebased so their already-reviewed diffs disappear from this PR.Validation
pytest -p no:cacheprovider -W error tests/splitter_tests/test_splitter_block_start_detection.py: 75 passed.tests/test_entrypoint.py.Review note
This changes the splitter's block-start grammar, so the draft should receive careful maintainer review despite the broad structural matrix. In particular, review should confirm the reserved-character set used to terminate entry-type identifiers and the decision to keep parenthesis syntax explicit but unsupported for now.
AI assistance
This pull request was prepared with ChatGPT Codex using GPT-5.6 Sol with high reasoning effort. Codex assisted with parser analysis, dependency separation, conflict resolution, test design, and validation. Automated validation is not a substitute for maintainer review.