Fix incomplete implementation of ETC2 textures in Vulkan - #7699
Open
Shivansps wants to merge 2 commits into
Open
Fix incomplete implementation of ETC2 textures in Vulkan#7699Shivansps wants to merge 2 commits into
Shivansps wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not realised i missed some functions that checked for compressed textures and that worked in all my devices... until i tested on a new one that crashed because of it.
I had to add a etc decoder header lib, "etcdec.h" this comes from the same origin and license of the "bcdec.h" used for DDS/BCn
Since a full ETC2 software decoder is added here, i might add in the future the posibility to software decompress ETC2 matching ddsutils function, what would be great for testing etc2 textures in desktop vulkan. But that is out of scope for this PR.