Skip to content

Update synthesizer cards to include TabDDPM and ClavaDDPM synthesizers - #645

Open
sarahmish wants to merge 1 commit into
mainfrom
issue-644-synthesizer-cards
Open

sarahmish wants to merge 1 commit into
mainfrom
issue-644-synthesizer-cards

Conversation

@sarahmish

Copy link
Copy Markdown
Contributor

Resolve #644

@sarahmish
sarahmish requested a review from a team as a code owner September 8, 2026 23:06
@sarahmish
sarahmish requested review from R-Palazzo and amontanez24 and removed request for a team September 8, 2026 23:06
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.48%. Comparing base (ca2ca4f) to head (7921988).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
- Coverage   86.49%   86.48%   -0.01%     
==========================================
  Files          42       42              
  Lines        5160     5159       -1     
==========================================
- Hits         4463     4462       -1     
  Misses        697      697              
Flag Coverage Δ
integration 56.05% <ø> (+0.01%) ⬆️
unit 76.21% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sarahmish sarahmish self-assigned this Sep 9, 2026

@R-Palazzo R-Palazzo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +140 to +141
modality: single_table
type: Deep Learning

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the website, we use type to describe the modality key, while type itself refers to something else. We may want to double-check this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@R-Palazzo the website will pull the modality from this sheet that's generated during the benchmark and it labels it with "Type". The fact that we use type to describe the method is confusing, however, we should keep it as is for now.

One thing that I'm worried about is why TabDDPM was never added to the sheet, but ClavaDDPM was. I think there might be something I missed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update model card for TabDDPM and ClavaDDPM

3 participants