Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2.0.0 #2991 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 66 66
Lines 7754 7758 +4
=======================================
+ Hits 7593 7597 +4
Misses 161 161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR! |
| 'range_values', | ||
| 'high_cardinality', |
There was a problem hiding this comment.
If we add high_cardinality here, we shouldn't need to pop it from the parameters in the the _get_ordinal_transformer and _get_categorical_transformer methods. Also, range_values should not be in this list, since we do want the range_values when instantiating ordinal transformers.
| table_str = f" for table '{table_name}'" if table_name else '' | ||
| sys.stdout.write(f'\nDetecting primary key{table_str}:\n') | ||
| _print_primary_key_detection(chosen_pk, sdtype_updated, pii_removed) | ||
| _print_primary_key_detection(chosen_pk) |
There was a problem hiding this comment.
Now that all the detection results are printed together at the end, I don't think we need to mention when the sdtype was updated anymore.
Before, it made sense because the output was printed during detection. Now it can be confusing to see sdtype='id' (updated to 'id') when we're already showing the final state.
Let me know if it makes sense this way.
SDV/sdv/metadata/_single_table.py
Line 852 in 9b7c327
3 participants
Resolve #2990
86bc1nxb8