Skip to content

fix(deps): patch npm transitive dependencies (GHSA-6prh-2h8m-c8cw, undici, @vitest/mocker) - #79

Merged
chmaltsp merged 1 commit into
mainfrom
security-sweep/root-npm-overrides
Nov 13, 2026
Merged

chmaltsp merged 1 commit into
mainfrom
security-sweep/root-npm-overrides

Conversation

@chmaltsp

Copy link
Copy Markdown
Contributor

Adds npm overrides and refreshes the lockfile:

Local: typecheck, lint, 250 tests pass.

Not fixed: copies nested inside the published @seamapi/cli -> @seamapi/wizard dev dependency (undici 8.9.0, fast-xml-parser 5.7.3, brace-expansion 5.0.9) are bundled and not reachable by overrides; minimatch GHSA-g3hv-75wg-m249 needs a major (11.x).

🤖 Generated with Claude Code

Override @modelcontextprotocol/client+core to 2.4.0 (GHSA-6prh-2h8m-c8cw),
undici ^8.12.4, brace-expansion 5.0.13, fast-xml-parser ^5.12.1 and
@vitest/mocker 4.1.12 (GHSA-qxg6-89mg-rqv8, GHSA-xp26-3454-mjgp).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T16:40:49.059933Z 6371bf4 PR opened
🔒 Security Review ✅ Completed 2026-11-13T16:40:36.668874Z 6371bf4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chmaltsp
chmaltsp merged commit 5ed0b1a into main Nov 13, 2026
11 checks passed
@chmaltsp
chmaltsp deleted the security-sweep/root-npm-overrides branch November 13, 2026 16:39

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6371bf400f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
"@modelcontextprotocol/core": "2.2.0"
"@modelcontextprotocol/client": "2.4.0",
"@modelcontextprotocol/core": "2.4.0",
"undici": "^8.12.4",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Patch transitive dependencies in the published package

For users installing the published @seamapi/wizard package, this does not enforce undici@8.12.4: npm only considers overrides in the root project and ignores overrides from installed dependencies. The consumer also does not use this repository's lockfile, so @earendil-works/pi-coding-agent continues to install its exact vulnerable undici@8.12.3; the other added security overrides have the same limitation. Patch or replace the declaring dependencies, or bundle the corrected resolutions, so the published artifact actually receives these fixes.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant