Skip to content

Add CMake uninstall target#848

Merged
fabianbs96 merged 1 commit into
secure-software-engineering:developmentfrom
e345ee:f-CMakeUninstallTarget
Jul 4, 2026
Merged

Add CMake uninstall target#848
fabianbs96 merged 1 commit into
secure-software-engineering:developmentfrom
e345ee:f-CMakeUninstallTarget

Conversation

@e345ee

@e345ee e345ee commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a top-level cmake uninstall target for PhASAR.
  • clean up empty PhASAR-owned install directories after uninstall.
  • Document sudo ninja uninstall in the build instructions.

Fixes #556

Validation

  • git submodule update --init --recursive
  • pre-commit run --files BUILD.md CMakeLists.txt cmake/cmake_uninstall.cmake.in
  • Docker-based full install/uninstall validation with LLVM 16 and clang-20:
    configure -> build -> install -> uninstall
  • Verified that uninstall removes installed PhASAR files and empty PhASAR-owned install directories.

Copilot AI review requested due to automatic review settings July 3, 2026 12:53
@e345ee e345ee requested review from MMory and fabianbs96 as code owners July 3, 2026 12:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a top-level CMake uninstall target to complement PhASAR’s existing install rules, and documents how to invoke it from Ninja builds.

Changes:

  • Adds a top-level uninstall custom target that runs a generated CMake script.
  • Introduces cmake_uninstall.cmake.in to remove files listed in install_manifest.txt and delete empty PhASAR-owned install directories.
  • Documents sudo ninja uninstall in BUILD.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
CMakeLists.txt Generates the uninstall script and registers a top-level uninstall target.
cmake/cmake_uninstall.cmake.in Implements uninstall behavior (remove installed files + cleanup empty directories).
BUILD.md Documents how to run the uninstall target from the build directory.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmake/cmake_uninstall.cmake.in
Comment thread CMakeLists.txt
@e345ee e345ee force-pushed the f-CMakeUninstallTarget branch from 48b7a0f to c6778b4 Compare July 3, 2026 13:05

@fabianbs96 fabianbs96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @e345ee, thanks for contributing to PhASAR!

lgtm

@fabianbs96 fabianbs96 merged commit 26de306 into secure-software-engineering:development Jul 4, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake Uninstall Target

3 participants