Improve flexible ISO8601 validation throughput#168
Open
trevorprater wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a fast path for
iso8601.Validwhen called withFlexible, which is the mode used by the existingBenchmarkValidatebenchmark. The fast path keeps the same validation rules but walks the string by index instead of repeatedly slicing throughreadDigits/readByte.I kept the existing generic flag path unchanged for non-
Flexiblecombinations.Validation:
I also ran a temporary differential test comparing
Validagainst the previous implementation for every flag combination over fixed edge cases and 50,000 deterministic randomized strings.Benchmark command:
benchstat:I found the initial direction while experimenting with Sleepy - https://sleepy.run/mcp, then manually reduced it to this smaller
Flexible-only patch and validated it locally.