Upgrade to Go 1.27.1 and address the lint findings it surfaces - #4098
Draft
masih wants to merge 12 commits into
Draft
Upgrade to Go 1.27.1 and address the lint findings it surfaces#4098masih wants to merge 12 commits into
masih wants to merge 12 commits into
Conversation
Upgrade the entire go module to latest go 1.27.1 and address lint issues, adjust CI builds, etc.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4098 +/- ##
==========================================
+ Coverage 61.36% 62.12% +0.76%
==========================================
Files 2191 2105 -86
Lines 192106 182253 -9853
==========================================
- Hits 117887 113233 -4654
+ Misses 62737 61742 -995
+ Partials 11482 7278 -4204
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
# Conflicts: # sei-cosmos/telemetry/wrapper.go
…n behavior changes, narrow nolints
…e go toolchain helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.25.6 is behind the toolchain the rest of the stack targets, and golangci-lint v2.8.0 does not run on Go 1.27. This moves the module, the Dockerfiles, and every workflow to Go 1.27.1 and golangci-lint v2.13.2, and fixes what the new linters report. The Go version is read from go.mod everywhere it is needed (a small
scripts/go-toolchain.shhandles the patch-lessgo 1.28shape), the frozenprecompiles/*/legacyandutils/helpers/legacytrees are excluded from lint in.golangci.ymlrather than edited, andprecompiles/p256/verifier.gois left byte-identical sobump_versiondoes not mint a new legacy copy.Two changes go beyond lint. Go 1.27's
compress/flateemits different bytes than Go 1.26 for the same input, which reaches state-sync snapshots through both the multistore zlib stream and the gzipped wasm code the wasm extension writes into it, so the multistore snapshot format is bumped from 1 to 2. Upgraded nodes restore both formats, but an old binary answersREJECT_FORMATto every snapshot an upgraded node serves, so operators should keep old-binary snapshot providers up until the rollout completes. Separately,CommitSig.FromProtonow rejects ablock_id_flagoutsideABSENT,COMMIT,NILat decode instead of truncating it throughuint8; a value such as257used to wrap toAbsentand passValidateBasic. Both are recorded in CHANGELOG.md.Smaller behavioural effects worth knowing about: the p2p mux now returns an error instead of silently truncating a frame header longer than 255 bytes, the Tendermint HTTP client dials with the request context so cancellation aborts a pending dial, and the EVM JSON-RPC error strings for malformed
eth_callarguments changed wording because Go 1.27 implementsencoding/jsonv1 as a shim over v2 (they still match geth, and the rpc integration tests were loosened accordingly, as were the exact-bytes gzip and JSON-error-text unit tests). The v2 shim promises identical marshal/unmarshal semantics; amino-JSON sign bytes and wasmvmEnv/Infoserialization were checked and the Determinism and geth-parity jobs pass. Releases up to release/v6.7 cannot be built with a Go 1.27 toolchain because of their pinnedcockroachdb/swiss, so the upgrade-test harness pins each worktree's toolchain from its own go.mod and operators building old tags need to do the same.