Skip to content

In-house 2FA - #4562

Merged
mdmintz merged 4 commits into
masterfrom
in-house-2fa
Nov 16, 2026
Merged

mdmintz merged 4 commits into
masterfrom
in-house-2fa

Conversation

@mdmintz

@mdmintz mdmintz commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

In-house 2FA

Since PyOTP 2.12.0 broke backwards compatibility, we're going to replace it with in-house 2FA algorithm to handle time-based 2-factor authentication. The algorithm will work exactly as it did before so that backwards-compatibility is retained for existing scripts.


Gemini-generated snippet:

Replace pyotp with standard library TOTP in get_mfa_code()

Maintains backwards compatibility with 16-character Base32 secrets
after pyotp 2.12.0 enforced a 112-bit minimum key length.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@://github.com>
Gemini Screenshot

Acknowledgments

  • Standard-library RFC 6238 TOTP implementation drafted with assistance from Google Gemini.

@mdmintz mdmintz self-assigned this Nov 16, 2026
@mdmintz mdmintz added enhancement Making things better dependencies This involves updating a dependency file SeleniumBase 4 SeleniumBase 4 labels Nov 16, 2026
@mdmintz
mdmintz merged commit 500b969 into master Nov 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies This involves updating a dependency file enhancement Making things better SeleniumBase 4 SeleniumBase 4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyOTP dependency (2.12.0) broke backwards compatibility

1 participant