Repository navigation
ci: run full-matrix linux jobs on preinstalled compilers - #67
Conversation
![biobo-bot[bot]](https://avatars.githubusercontent.com/in/5358509?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM. Pinning the full-matrix Linux jobs to ubuntu-24.04 is the right fix for the clang-14 / clang-16 install failures on the 26.04 image, and it brings ci-full.yml in line with ci-pr.yml, ci.yml, clang-tidy.yml and fuzz.yml, which already run on ubuntu-24.04. The explanatory comment mirrors the existing windows-2022 pin nicely.
Two non-blocking notes:
- The comment sits under the
===== GCC =====header but applies to every Linux entry (Clang too). Moving it above the GCC header would make that a bit clearer. ubuntu-24.04will eventually be retired too, so at some point it may be worth installing older clangs fromapt.llvm.org(or dropping clang-14 from the matrix) rather than relying on the distro archive. Fine to leave for a follow-up.
Approving; merge once the matrix goes green.
Benchmark comparison (informational)Base Noise estimate: the 20 control rows below do not run Patternia code, so they should not change between base and PR. As a group they moved by a median of +0.0% (run order and machine drift); that offset is divided out of the Patternia deltas (Adjusted). The controls then scatter by a median of 0.8%. Adjusted differences under 5.0% are treated as noise. Patternia: 8 benchmarks, 0 slower, 1 faster, 7 within noise.
Control rows (not Patternia code)
Raw results and the comparison chart are attached to this workflow run as an artifact. Shared runners are noisy, so use this as a trend, not a measurement. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Problem - ubuntu-latest now resolves to Ubuntu 26.04 (resolute), which no longer ships clang-14 or clang-16. The required clang-14 C++17 and clang-16 C++20 jobs fail at apt-get install, blocking every PR. Implementation - Pin all Linux entries of the ci-full matrix to ubuntu-24.04, which carries gcc-11, gcc-13, clang-14, clang-16 and clang-18. - Leave a comment next to the matrix, matching the existing windows-2022 pin. Tests - Verified by this PR's own CI run.
a0c00cf to
6613f62
Compare
sentomk
changed the title
Summary
ubuntu-latestnow resolves to Ubuntu 26.04 (resolute), whose archive no longer shipsclang-14orclang-16. The requiredclang-14 C++17andclang-16 C++20jobs fail atapt-get install(seen on #66), so every PR is blocked. This pins the full-matrix Linux runners toubuntu-24.04.Changes
ci-full.ymltoubuntu-24.04, which carries gcc-11, gcc-13, clang-14, clang-16 and clang-18.windows-2022pin.Testing
E: Package 'clang-14' has no installation candidate(and the same for clang-16).🤖 Generated with Claude Code