Skip to content

feat: The phone preview frame looks like a generic iPhone - #1

Merged
vlidholt merged 1 commit into
mainfrom
preview-phone-frame
Nov 15, 2026
Merged

vlidholt merged 1 commit into
mainfrom
preview-phone-frame

Conversation

@vlidholt

Copy link
Copy Markdown
Contributor

Summary

  • The phone preview frame is redrawn as a generic iPhone: a thin black outline, a metal rim, a dark grey line, and the black frame.
  • Side buttons are beveled and metal-coloured, and they turn with the device in landscape.
  • The drop shadow is larger and darker, closer to a macOS window's.
  • Screen corner radius grows to 36 (body 46). The frame box gains a 3pt hardware overhang on every side, so the buttons stay inside the window bounds.

Drawing lives in lib/preview/phone_chassis_painter.dart; preview_device.dart holds the geometry constants and preview_pane.dart uses the painter.

Notes

  • The compact window's 40pt margin limits how far the shadow can spread. A softer, wider shadow would need a larger kCompactFrameMargin.
  • Visual check was done with scratch renders of the painter; the compact window itself was not exercised in the running app.

Test plan

  • flutter test test/preview (16 passed)
  • Check the compact and full windows in the running app, both orientations, light and dark

🤖 Generated with Claude Code

The bezel is a metal outline, a metal rim, a dark grey line and a black
frame, with side buttons that are beveled and turn with the device. The
shadow is larger and darker, closer to a macOS window's.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@vlidholt
vlidholt merged commit 15c0d32 into main Nov 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant