Repository navigation
feat: App Studio gets its new app icon on macOS and Windows - #3
Merged
Merged
Conversation
macOS takes the AppIcon set's PNGs (Apple's 1024 grid, 824 px tile); Windows takes the set's own .ico, 16 to 256 px, which the installer uses too. The Windows artwork is no longer the macOS one, so tool/windows/make_icon.dart, which built the .ico from the macOS PNGs, would now overwrite it and is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…icon. ASSETCATALOG_COMPILER_APPICON_NAME named AppStudio, an Icon Composer icon with the old logo, so the new PNGs in AppIcon.appiconset never reached the app. The build now names AppIcon and AppStudio.icon is removed. macOS 27 draws the flat icon without a frame. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the app icon on both platforms with the new icon set.
macos/Runner/Assets.xcassets/AppIcon.appiconset/come from the set'sAppIcon.iconset/(Apple's 1024 grid, 824 px tile).ASSETCATALOG_COMPILER_APPICON_NAMEnamedAppStudio, an Icon ComposerAppStudio.iconwith the old logo, so the PNGs never reached the app. It now namesAppIcon, andAppStudio.iconis removed.windows/runner/resources/app_icon.icois the set's own.ico, 16 to 256 px.Runner.rcand the Inno Setup installer (SetupIconFile) both read it.tool/windows/make_icon.dartis removed. It built the.icofrom the macOS PNGs. The Windows icon now has its own artwork, a larger tile without Apple's margin, so running the script would overwrite it with the macOS one.specs/windows_port.mdandAGENTS.mdsay so.Not included: Icon Composer layers for the dark, clear and tinted appearances (the flat icon is shown in all of them), and the MSIX logo PNGs, which the Inno Setup installer does not use.
Verified: the asset catalog compiles with
xcrun actool; both build configurations resolve the icon name toAppIcon; and the compiled icon, rendered by macOS 27 throughNSWorkspace.icon(forFile:), shows the new artwork with no grey frame. Not yet seen in a full app build or on Windows.🤖 Generated with Claude Code