Conversation
The original jscolour still exists for Quake 1, but it is slower, has build issues with recent compilers, produces dark spots in some areas, and is now unmaintained. While supporting both at runtime is awkward without C++ (ericw-tools does this), relatively few changes are needed to support both at build time. You can choose a Quake 1 build with `make GAME=quake1`. The object files are separated to avoid cross contamination in the final binaries.
Owner
|
I can't say that I like the top-level change to bspfile.h, but I guess there's no helping it.. I'll look at this more closely, hopefully soon.. In the meantime, did you look at Juraj Styk's jscolor source for any possible missing quake bits? |
Contributor
Author
|
I based this on dsvensson/jscolour, which seems to be based on that. Admittedly, I only did enough to make it not fall over, so I'll check again to see if there are any other significant differences. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original jscolour still exists for Quake 1, but it is slower, has build issues with recent compilers, produces dark spots in some areas, and is now unmaintained.
While supporting both at runtime is awkward without C++ (ericw-tools does this), relatively few changes are needed to support both at build time.
You can choose a Quake 1 build with
make GAME=quake1. The object files are separated to avoid cross contamination in the final binaries.I have tested this with the original Quake 1, Scourge of Armagon, and Dissolution of Eternity. The latter needed a small workaround. I obviously haven't checked every single map, but I've had a quick look round the first few, and I haven't seen any bad results, unlike with the original jscolour.
If you prefer, I can call the alternative build jsq1colour or something, but I thought it made sense to keep the original name.