Repository navigation
test: split validation tests by conformance level (#74) - #83
Merged
Merged
Conversation
test_validation.py had grown to 995 lines. Split it into report, wire, profile, and file_types modules that mirror fit_tool/validation/, with the shared activity/course builders in validation_helpers. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a180a3-b0f6-711b-bca9-09e4a1f830d0
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage 93.03% 93.03%
=======================================
Files 46 46
Lines 2728 2728
Branches 425 425
=======================================
Hits 2538 2538
Misses 109 109
Partials 81 81 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #74: the validation package split landed in #82, but its test file was still a single 995-line module.
test_validation.pyintotest_validation_report.py,test_validation_wire.py,test_validation_profile.py, andtest_validation_file_types.py, mirroringfit_tool/validation/.validation_helpers.py.test_profile_scope.pyintotest_validation_profile.py, so catalog, coverage, and scope tests live with the rest of the PROFILE-level tests.No tests removed: the validation suite still runs the same 47 tests.
Verification
uv run ruff check fit_tool— cleanuv run mypy— 3 files, successuv run pytest -q— 447 passed, 1 skipped