Repository navigation
chore: upgrade garmin fit sdk profile version 21.221.0 - #87
Merged
Merged
Conversation
Replace the bundled Garmin Profile spreadsheet with 21.221.0 from garmin/fit-sdk-tools, bump SDK_VERSION, and regenerate typed profile code. The profile delta adds three sonar/dive messages (364-366), 27 new fields, four enum types, and 58 new enum values, including the tsb_sonar_events and tsb_diver_config file types plus descent_x10, edge_1060, edge_explore3, marq3, and new manufacturer ids. Catalog counts move to 127 messages / 1593 fields / 119 enum types; the change is purely additive with no field removals or type changes. Update hardcoded profile version and count snapshots in tests. Closes #86 Amp-Thread-ID: https://ampcode.com/threads/T-01a1aed6-c30e-76c7-93f7-cd4b34cd460b
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=======================================
Coverage 93.03% 93.03%
=======================================
Files 46 46
Lines 2728 2728
Branches 425 425
=======================================
Hits 2538 2538
Misses 109 109
Partials 81 81 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the bundled Garmin FIT SDK Profile from
21.218.0to21.221.0, sourced from theProfile.xlsxasset of garmin/fit-sdk-tools 21.221.0 (278,545 bytes, sha256f7aebc64…7109052).The upstream release changed only
Profile.xlsxand the two tool jars, so this is a data-only bump. The profile delta is purely additive: no existing field was removed, renamed, or retyped.New messages
tsb_sonar_message_event(364) — 4 fieldstsb_settings(365) — 17 fields, includesfloat32[3]calibration arraystsb_diver_config(366) — 6 fields, includes variable-lengthdiver_nameNew types:
sonar_heading,sonar_message_source,sonar_message_type,sonar_packet_idNew enum values in existing types
file:tsb_sonar_events(66),tsb_diver_config(67)garmin_product:edge_1060,edge_explore3,edge_explore3_plus,marq3,descent_x10manufacturer:fair_weather_athletics,hatch_factory,torqano,rockbrosmesg_num: 364–366Changes
fit_tool/gen/Profile_21.218.0.xlsxwithProfile_21.221.0.xlsx; bumpSDK_VERSION.message_factory, plusfield_catalog,profile_type, andcomponent_registry. 126 of the 129 modified generated files change only the# Profile:header line.test_validation_profile.py,test_public_api.py,test_garmin_sdk_interop.py, andtest_fit_file_header.py.README.md,docs/CAPABILITY_BOUNDARY.md,docs/EPIC_SHA12_RELEASE_NOTES.md,docs/FIT_CONFORMANCE_DESIGN.md, andfit_tool/tests/data/README.md.news/86.dep.Verification
uv run pytest -q— 447 passed, 1 skipped (the skip needsFIT_JS_SDK_PATH+ Node).uv run ruff check fit_tool— clean;uv run mypy— clean.uv run gen-profilere-run after staging — no diff (generator idempotent).uv build— wheel contains the three new message modules.TsbSettingsMessage,TsbDiverConfigMessage, andTsbSonarMessageEventMessageencode, decode with expected values, and re-encode byte-identically.palisade.fit,activity_multiple_developer_index.fit, andstagesLink_25622166.fitstill re-encode byte-identically.Notes
filetypes 66/67 have no FILE_TYPE validator, so strict validation of such files fails closed with the existing "not implemented" finding, consistent with other unimplemented file types. No validator was added because the message requirements are not documented.Closes #86