Skip to content

#89 update deps - #90

Open
mumenthalers wants to merge 6 commits into
mainfrom
#89-update-deps
Open

mumenthalers wants to merge 6 commits into
mainfrom
#89-update-deps

Conversation

@mumenthalers

Copy link
Copy Markdown
Contributor

closes #89

Copilot AI balanced review requested due to automatic review settings October 5, 2026 07:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The release-age safeguard is unsupported by the declared minimum npm version.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Updates the monorepo and publish helper to Lerna 10 to reduce dependency risks.

Changes:

  • Upgrades Lerna to 10.0.1.
  • Adds npm funding and release-age settings.
File Description
package.json Upgrades root Lerna dependency.
packages/​publish-helper/​package.json Requires Lerna 10 as a peer.
.npmrc Configures npm funding and release-age behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .npmrc
Copilot AI balanced review requested due to automatic review settings October 5, 2026 08:59
 - @shiftcode/airtable-syncer@1.0.3-pr89.0
 - @shiftcode/iac-utilities@1.0.3-pr89.0
 - @shiftcode/inversify-logger@1.0.1-pr89.0
 - @shiftcode/lambda-utilities@1.0.2-pr89.0
 - @shiftcode/nest-logger@1.0.2-pr89.0
 - @shiftcode/publish-helper@7.0.0-pr89.0

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The dependency upgrade and associated test and npm configuration changes are coherent with the stated goal.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Copilot AI balanced review requested due to automatic review settings October 5, 2026 09:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The declared and tested Node 25 support conflicts with Lerna 10’s supported Node versions.

Review effort: Balanced
Findings: 1 High severity

Open (1)
Previously missed (1)

In code that hasn't changed since last review

Medium severity Package Node engine range conflicts with Lerna 10 requirements

packages/​publish-helper/​package.json:33

This peer dependency makes Lerna 10 part of the publish helper's runtime contract, but the package still advertises Node >=24.10.2, including unsupported Node 25. Consumers enforcing engines cannot satisfy that advertised runtime together with Lerna 10's ^22.13.0 || ^24.0.0 || ^26.0.0 requirement. Narrow this package's Node engine to the supported majors.

Comment thread package.json
"eslint": "^9.36.0",
"husky": "^9.0.11",
"lerna": "^9.0.3",
"lerna": "^10.0.1",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update deps

3 participants