Conversation
Change-Id: Id4eabbcd70df8b594d26ee2fba777783f518f070
Change-Id: I89db58bf48ffb14b8c8edcaed8ae26549a7a522a
johnml1135
reviewed
Jul 9, 2026
johnml1135
left a comment
Contributor
There was a problem hiding this comment.
Claude - Sonnet 5 — automated code review.
Two additional findings sit on lines outside this PR's diff hunks (pre-existing code untouched here), so they can't be attached as inline comments — noting them here instead:
- Reuse (
Src/Utilities/pcpatrflex/ToneParsFLExDll/ToneParsInvoker.cs~line 101):ConvertNameToUseAnsiCharactersis a byte-for-byte duplicate ofXAmpleParser.ConvertNameToUseAnsiCharacters, explicitly commented as "borrowed from SIL.FieldWorks.WordWorks.Parser (ParserCore.dll)". Since this PR already dedupesProcessParseResultsagainst the same class, andToneParsInvokernow holds a liveXAmpleParserreference, this is a natural candidate to dedupe too (note:XAmpleParser's version isinternal static, so calling through would need an accessibility change). - Cleanup (
Src/Utilities/pcpatrflex/ToneParsFLExDll/ToneParsInvoker.csline 22):using System.Xml.Linq;is now dead — it was the only consumer's (XElement/Descendants) namespace, and that code was deleted by this PR. No remaining use of anySystem.Xml.Linqtype in the file.
Change-Id: Iec04860ae004f83adf3c64cf9d54848ecf423906
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the TonePars utility is part of FLEx, we can have it use the same code that XAmple does when processing its result.
This change is