Fix LT-20950: Add New Sense dialog uses wrong Morph Type - #1019
Merged
Conversation
mark-sil
approved these changes
Jul 21, 2026
mark-sil
left a comment
mark-sil
left a comment
Contributor
There was a problem hiding this comment.
@mark-sil reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jtmaxwell3).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1019 +/- ##
==========================================
- Coverage 32.99% 32.99% -0.01%
==========================================
Files 1202 1202
Lines 278209 278209
Branches 37160 37160
==========================================
- Hits 91789 91788 -1
Misses 158563 158563
- Partials 27857 27858 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-20950. le.AlternateFormsOS only consists of the alternate allomorphs, le.AllAllomorphs consists of the lexeme and the alternative allomorphs. le.AlternateFormsOS didn't find anything if there were no alternate allomorphs. This worked for stems but not affixes. In the description the -se affix had an alternate allomorph and so it worked, whereas the -s affix didn't have an alternative allomorph and so it didn't work. Switching to le.AllAllomorphs fixed the problem.
This change is