LT-22609: Crash when creating New Project with trailing space in name - #1021
Closed
thejambi wants to merge 2 commits into
Closed
LT-22609: Crash when creating New Project with trailing space in name#1021thejambi wants to merge 2 commits into
thejambi wants to merge 2 commits into
Conversation
added 2 commits
July 17, 2026 16:51
https://jira.sil.org/browse/LT-22578. ShowDialog calls needed to properly pass an `owner` parameter for the windows to behave as expected.
[LT0-22609](https://jira.sil.org/browse/LT-22609). Trimming project name before file creation to fix the issue. Added FwNewLangProjectModel_ProjectName_TrimsSurroundingWhitespace tests to ensure project name leading or trailing spaces are trimmed.
|
commit db0f03da6a: |
Contributor
Author
|
Nevermind - closing this as I accidentally included changes for another issue as well. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
==========================================
+ Coverage 32.99% 33.03% +0.03%
==========================================
Files 1202 1202
Lines 278175 278193 +18
Branches 37152 37160 +8
==========================================
+ Hits 91781 91888 +107
+ Misses 158543 158465 -78
+ Partials 27851 27840 -11
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick Summary
Fix LT-22609: FLEx crashes when creating a New Project with a trailing space in the Project name
LT0-22609. Trimming project name before file creation to fix the issue. Added FwNewLangProjectModel_ProjectName_TrimsSurroundingWhitespace tests to ensure project name leading or trailing spaces are trimmed.
CI-ready checklist
.github/commit-guidelines.md(subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).Docs/workflows/ai-pr-workflow.mdand ranpr-preflightor the equivalent branch-readiness review before requesting review.Src/**folders touched, correspondingAGENTS.mdfiles are updated or explicitly confirmed still accurate.This change is