Skip to content

LT-22609: Crash when creating New Project with trailing space in name - #1021

Closed
thejambi wants to merge 2 commits into
mainfrom
bugfix/LT-22609
Closed

LT-22609: Crash when creating New Project with trailing space in name#1021
thejambi wants to merge 2 commits into
mainfrom
bugfix/LT-22609

Conversation

@thejambi

@thejambi thejambi commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Quick Summary

Fix LT-22609: FLEx crashes when creating a New Project with a trailing space in the Project name
LT0-22609. Trimming project name before file creation to fix the issue. Added FwNewLangProjectModel_ProjectName_TrimsSurroundingWhitespace tests to ensure project name leading or trailing spaces are trimmed.

CI-ready checklist

  • Commit messages follow .github/commit-guidelines.md (subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).
  • No whitespace warnings locally:
    git fetch origin
    git log --check --pretty=format:"---% h% s" origin/<base>..
    git diff --check --cached
  • Builds/tests pass locally (or I've run the CI-style build via Bash script or MSBuild).
  • If this is core-developer AI-assisted work, I followed Docs/workflows/ai-pr-workflow.md and ran pr-preflight or the equivalent branch-readiness review before requesting review.
  • For any Src/** folders touched, corresponding AGENTS.md files are updated or explicitly confirmed still accurate.

This change is Reviewable

Zachary Burnham added 2 commits July 17, 2026 16:51
https://jira.sil.org/browse/LT-22578. ShowDialog calls needed to properly pass an `owner` parameter for the windows to behave as expected.
[LT0-22609](https://jira.sil.org/browse/LT-22609).
Trimming project name before file creation to fix the issue.
Added FwNewLangProjectModel_ProjectName_TrimsSurroundingWhitespace tests
to ensure project name leading or trailing spaces are trimmed.
@github-actions

Copy link
Copy Markdown

⚠️ Commit Message Format Issues ⚠️

commit db0f03da6a:
2: B1 Line exceeds max length (138>80): "https://jira.sil.org/browse/LT-22578. ShowDialog calls needed to properly pass an owner parameter for the windows to behave as expected."
2: B4 Second line is not empty: "https://jira.sil.org/browse/LT-22578. ShowDialog calls needed to properly pass an owner parameter for the windows to behave as expected."

@thejambi thejambi closed this Jul 21, 2026
@thejambi
thejambi deleted the bugfix/LT-22609 branch July 21, 2026 20:47
@thejambi

Copy link
Copy Markdown
Contributor Author

Nevermind - closing this as I accidentally included changes for another issue as well.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.03%. Comparing base (b30d631) to head (017c87f).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...c/Common/Controls/DetailControls/ChooserCommand.cs 0.00% 0 Missing and 1 partial ⚠️
Src/LexText/Morphology/InflAffixTemplateControl.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1021      +/-   ##
==========================================
+ Coverage   32.99%   33.03%   +0.03%     
==========================================
  Files        1202     1202              
  Lines      278175   278193      +18     
  Branches    37152    37160       +8     
==========================================
+ Hits        91781    91888     +107     
+ Misses     158543   158465      -78     
+ Partials    27851    27840      -11     
Files with missing lines Coverage Δ
Src/FwCoreDlgs/FwNewLangProjectModel.cs 79.59% <100.00%> (ø)
...c/Common/Controls/DetailControls/ChooserCommand.cs 0.00% <0.00%> (ø)
Src/LexText/Morphology/InflAffixTemplateControl.cs 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants