Skip to content

Fix LT-22633 - #1025

Merged
AndyBlack merged 1 commit into
mainfrom
LT22633
Jul 23, 2026
Merged

Fix LT-22633#1025
AndyBlack merged 1 commit into
mainfrom
LT22633

Conversation

@AndyBlack

@AndyBlack AndyBlack commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

We have two places where we display information in a web browser. We allow users to invoke a Find dialog so they can more easily find what they are looking for. There were two places where invoking the Find dilaog could cause a crash. The reporter for LT-22633 found one of them.

The fix in GeneratedHtmlViewer.cs is for the case the reporter found.

The fix in TryAWordDlg.cs is for the other case I found. The simplest solution for it is to only allow the user to invoke the Find dialog when TryAWord is showing a parsing result page. There is no need to let the user look for something with either the initial message page or the while trrying page.

There was a typo in the InitialDocument.htm title which is fixed (not that this is crucial...).


This change is Reviewable

Change-Id: I8fd90f185eb1ba632b84f07e832a919291327c41
@github-actions

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   10m 21s ⏱️ -48s
4 313 tests ±0  4 240 ✅ ±0  73 💤 ±0  0 ❌ ±0 
4 322 runs  ±0  4 249 ✅ ±0  73 💤 ±0  0 ❌ ±0 

Results for commit 2ab6dbe. ± Comparison against base commit 7176e6c.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.02%. Comparing base (7176e6c) to head (2ab6dbe).

Files with missing lines Patch % Lines
Src/xWorks/GeneratedHtmlViewer.cs 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
- Coverage   33.02%   33.02%   -0.01%     
==========================================
  Files        1202     1202              
  Lines      278232   278236       +4     
  Branches    37169    37170       +1     
==========================================
- Hits        91889    91881       -8     
- Misses     158495   158505      +10     
- Partials    27848    27850       +2     
Files with missing lines Coverage Δ
Src/xWorks/GeneratedHtmlViewer.cs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thejambi thejambi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!
:lgtm:

@thejambi reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on AndyBlack).

@AndyBlack
AndyBlack merged commit ac89f08 into main Jul 23, 2026
7 checks passed
@AndyBlack
AndyBlack deleted the LT22633 branch July 23, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants