Conversation
Change-Id: I8fd90f185eb1ba632b84f07e832a919291327c41
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
- Coverage 33.02% 33.02% -0.01%
==========================================
Files 1202 1202
Lines 278232 278236 +4
Branches 37169 37170 +1
==========================================
- Hits 91889 91881 -8
- Misses 158495 158505 +10
- Partials 27848 27850 +2
🚀 New features to boost your workflow:
|
thejambi
approved these changes
Jul 23, 2026
thejambi
left a comment
Contributor
There was a problem hiding this comment.
@thejambi reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on AndyBlack).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have two places where we display information in a web browser. We allow users to invoke a Find dialog so they can more easily find what they are looking for. There were two places where invoking the Find dilaog could cause a crash. The reporter for LT-22633 found one of them.
The fix in GeneratedHtmlViewer.cs is for the case the reporter found.
The fix in TryAWordDlg.cs is for the other case I found. The simplest solution for it is to only allow the user to invoke the Find dialog when TryAWord is showing a parsing result page. There is no need to let the user look for something with either the initial message page or the while trrying page.
There was a typo in the InitialDocument.htm title which is fixed (not that this is crucial...).
This change is