Skip to content

LT-22788: Put the parse-words-in-text choices in a submenu - #1149

Merged
jasonleenaylor merged 2 commits into
mainfrom
LT-22788-parse-words-submenu
Sep 22, 2026
Merged

jasonleenaylor merged 2 commits into
mainfrom
LT-22788-parse-words-submenu

Conversation

@jasonleenaylor

@jasonleenaylor jasonleenaylor commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Turn the Parser menu's "Parse Words in Text" item into a submenu holding
"All Words in Text" and "Words Without an Approved Analysis". The second one
runs what the separate "Parse Unapproved Words in Text" item used to run, so
that item is gone.

The listener handlers are renamed to match the new commands, and the wordform
helper is named after what it collects, which leaves "unapproved" free for the
third choice LT-22789 adds. The submenu gets its own display handler so the
whole thing hides when there is no current text, as both items did before.

Verification

Ran the acceptance test from LT-22788 against a Debug build of this branch,
using the attached project English-Test Parsing Scenarios-Reduced:

  • Parser menu shows "Parse Words in Text" with the two submenu items, and no
    "Parse Unapproved Words in Text" anywhere.
  • Text 00a, "Words Without an Approved Analysis" → "Parsed 2 word(s)",
    "living" turns tan, "lived" stays cyan. Matches 02-AfterTestWithoutApproved.png.
  • Text 00b, "All Words in Text" → "Parsed 6 word(s)", "stating" goes from a
    light-blue to a tan outline. Matches 04-AfterTestParseAllWords.png.
  • Word Analyses tool, where there is no current text: the submenu is absent
    rather than present and empty.

Not checked: the sub-steps that open the analysis dropdown on "stating" to
inspect the approved-by rectangles (graphics 05 and 06). The Views control
exposes nothing to UI automation, and the box's colour change after parse-all
shows the same fact.

Second commit

Make the fieldworks-winapp scripts run under Windows PowerShell 5.1 fixes two
scripts that blocked the verification above. Preflight-WinFormsMcp.ps1 and
Resolve-FieldWorksDevRegistry.ps1 have no UTF-8 BOM, so PowerShell 5.1 reads
each em dash as three cp1252 characters ending in a curly quote, which closes
the enclosing string and kills the parse far from the real line. The preflight
also used two PS7-only ?.Source expressions. Windows PowerShell 5.1 is the
only PowerShell on this box, so neither script ran at all.

🤖 Generated with Claude Code


This change is Reviewable

Turn the Parser menu's "Parse Words in Text" item into a submenu holding
"All Words in Text" and "Words Without an Approved Analysis". The second
one runs what the separate "Parse Unapproved Words in Text" item used to
run, so that item is gone.

Rename the listener handlers to match the new commands, and name the
wordform helper after what it collects. "Unapproved" is left free for the
third choice LT-22789 adds. The submenu gets its own display handler so
the whole thing hides when there is no current text, as both items did
before.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

Comment hygiene (advisory)

No comment-style violations in the lines this branch adds since origin/main.

Replace the em dashes in Preflight-WinFormsMcp.ps1 and
Resolve-FieldWorksDevRegistry.ps1 with ASCII. Neither file has a UTF-8
BOM, so PowerShell 5.1 decodes each em dash as three cp1252 characters,
the last of which is a curly quote that ends the enclosing string. The
registry script died on a line 14 lines past the one it named.

Also expand the two null-conditional `?.Source` expressions in the
preflight, which PowerShell 5.1 cannot parse at all. Both scripts now
run to completion under 5.1, which is the only PowerShell on a stock
FieldWorks dev box.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@jasonleenaylor
jasonleenaylor force-pushed the LT-22788-parse-words-submenu branch from 5eb810d to 25e7168 Compare September 21, 2026 22:55
@github-actions

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   12m 47s ⏱️ +24s
6 197 tests ±0  6 112 ✅ ±0  85 💤 ±0  0 ❌ ±0 
6 206 runs  ±0  6 121 ✅ ±0  85 💤 ±0  0 ❌ ±0 

Results for commit 25e7168. ± Comparison against base commit 2f1d9db.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.88%. Comparing base (2f1d9db) to head (25e7168).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
- Coverage   38.89%   38.88%   -0.01%     
==========================================
  Files        1518     1518              
  Lines      352262   352262              
  Branches    40597    40597              
==========================================
- Hits       137005   136983      -22     
- Misses     185976   185997      +21     
- Partials    29281    29282       +1     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mark-sil mark-sil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on jasonleenaylor).

@jasonleenaylor
jasonleenaylor merged commit c7d2910 into main Sep 22, 2026
9 checks passed
@jasonleenaylor
jasonleenaylor deleted the LT-22788-parse-words-submenu branch September 22, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants