LT-22788: Put the parse-words-in-text choices in a submenu - #1149
Merged
Merged
Conversation
Turn the Parser menu's "Parse Words in Text" item into a submenu holding "All Words in Text" and "Words Without an Approved Analysis". The second one runs what the separate "Parse Unapproved Words in Text" item used to run, so that item is gone. Rename the listener handlers to match the new commands, and name the wordform helper after what it collects. "Unapproved" is left free for the third choice LT-22789 adds. The submenu gets its own display handler so the whole thing hides when there is no current text, as both items did before. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Comment hygiene (advisory)No comment-style violations in the lines this branch adds since |
Replace the em dashes in Preflight-WinFormsMcp.ps1 and Resolve-FieldWorksDevRegistry.ps1 with ASCII. Neither file has a UTF-8 BOM, so PowerShell 5.1 decodes each em dash as three cp1252 characters, the last of which is a curly quote that ends the enclosing string. The registry script died on a line 14 lines past the one it named. Also expand the two null-conditional `?.Source` expressions in the preflight, which PowerShell 5.1 cannot parse at all. Both scripts now run to completion under 5.1, which is the only PowerShell on a stock FieldWorks dev box. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
jasonleenaylor
force-pushed
the
LT-22788-parse-words-submenu
branch
from
September 21, 2026 22:55
5eb810d to
25e7168
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1149 +/- ##
==========================================
- Coverage 38.89% 38.88% -0.01%
==========================================
Files 1518 1518
Lines 352262 352262
Branches 40597 40597
==========================================
- Hits 137005 136983 -22
- Misses 185976 185997 +21
- Partials 29281 29282 +1 🚀 New features to boost your workflow:
|
mark-sil
approved these changes
Sep 22, 2026
mark-sil
left a comment
Contributor
There was a problem hiding this comment.
@mark-sil reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jasonleenaylor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn the Parser menu's "Parse Words in Text" item into a submenu holding
"All Words in Text" and "Words Without an Approved Analysis". The second one
runs what the separate "Parse Unapproved Words in Text" item used to run, so
that item is gone.
The listener handlers are renamed to match the new commands, and the wordform
helper is named after what it collects, which leaves "unapproved" free for the
third choice LT-22789 adds. The submenu gets its own display handler so the
whole thing hides when there is no current text, as both items did before.
Verification
Ran the acceptance test from LT-22788 against a Debug build of this branch,
using the attached project English-Test Parsing Scenarios-Reduced:
"Parse Unapproved Words in Text" anywhere.
"living" turns tan, "lived" stays cyan. Matches
02-AfterTestWithoutApproved.png.light-blue to a tan outline. Matches
04-AfterTestParseAllWords.png.rather than present and empty.
Not checked: the sub-steps that open the analysis dropdown on "stating" to
inspect the approved-by rectangles (graphics 05 and 06). The Views control
exposes nothing to UI automation, and the box's colour change after parse-all
shows the same fact.
Second commit
Make the fieldworks-winapp scripts run under Windows PowerShell 5.1fixes twoscripts that blocked the verification above.
Preflight-WinFormsMcp.ps1andResolve-FieldWorksDevRegistry.ps1have no UTF-8 BOM, so PowerShell 5.1 readseach em dash as three cp1252 characters ending in a curly quote, which closes
the enclosing string and kills the parse far from the real line. The preflight
also used two PS7-only
?.Sourceexpressions. Windows PowerShell 5.1 is theonly PowerShell on this box, so neither script ran at all.
🤖 Generated with Claude Code
This change is