LT-22801: Retain patch MSIs on request - #93
Merged
Merged
Conversation
Allow the patch workflow to inspect the generated Master and Update MSIs before its component ledger check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start here: FieldWorks now checks a patch against both its base MSI and its previous-patch component ledger.
buildPatch.batdeleted the generated Master and Update MSIs immediately after producing the MSP, so the new check had no MSI inputs.When
KEEP_INTERMEDIATE_MSI=true, retain those two MSI files for the caller. Existing callers keep the current cleanup behavior. FieldWorks #1147 sets the flag and consumes the files for its S3-only ledger check.Validation: exercised the cleanup block with the flag enabled and disabled; both MSIs were preserved only when requested. The integrated FieldWorks patch run is 35722248879.
This change is