Fix transform to convert empty strings to NULL when changing to integer or float type#785
Open
ikatyal2110 wants to merge 1 commit into
Open
Conversation
…o integer or float type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you run
.transform(types={"age": int})on a table that has empty strings in a TEXT column, the empty strings currently survive as""in the new INTEGER/FLOAT column instead of becoming NULL.The fix wraps the SELECT expression with
NULLIF(col, '')for any column explicitly being converted to a numeric type, so empty strings become NULL during the data copy step.Text columns and columns not listed in
typesare not affected.Fixes #488
📚 Documentation preview 📚: https://sqlite-utils--785.org.readthedocs.build/en/785/